Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpcgap: get rid of backquote alias for MakeImmutable #2202

Merged
merged 1 commit into from
Mar 10, 2018
Merged

hpcgap: get rid of backquote alias for MakeImmutable #2202

merged 1 commit into from
Mar 10, 2018

Conversation

fingolfin
Copy link
Member

The backquote / backtick syntax always was controversial, and with the whole unification project, we already got rid of most of its uses. This PR removes the last few remaining uses, and the implementation.

@fingolfin fingolfin added topic: HPC-GAP Issues and PRs related to HPC-GAP topic: HPC-GAP unification labels Feb 23, 2018
ChrisJefferson
ChrisJefferson approved these changes Mar 2, 2018
View reviewed changes
src/read.c
TRY_READ { IntrFuncCallEnd(1, 0, 1); }
break;
#endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thought, is there enough hpc-gap code out there that we should put a SyntaxError here telling people that ` should be rewritten as MakeImmutable?

@ChrisJefferson
Copy link
Contributor

Two things, as I mention in my review I wonder if we should make a SyntaxError just to let people know what's going on if they load old HPC-GAP demos.

Also, we should cherry-pick this into 4.9 after merging I think, to stop people using backtick in 4.9 releases.

@fingolfin fingolfin added this to the GAP 4.9.1 milestone Mar 2, 2018
@fingolfin
Copy link
Member Author

I guess a cherry pick into stable-4.9 is a good idea.

As to the SyntaxError -- hrm, that's more work that later also need to be undone, i.e. even more work. Do we really need this? As it is, there are not that many people using HPC-GAP, most of which are in close contact with us anyway. And I am pretty hopeful that they would either guess the reason, or else contact us via GAP support or the issue tracker for help, once they start to get syntax errors caused by backticks, like this one:

gap> `"123";
Syntax error: expression expected
`"123";
^

We'd also put this change in the CHANGES list for GAP 4.9.1, then the few people who don't take regularly to us can find out about the backtick there, too.

@fingolfin fingolfin merged commit 903cdfc into gap-system:master Mar 10, 2018
@fingolfin fingolfin deleted the mh/no-backquote branch March 10, 2018 16:42
@fingolfin
Copy link
Member Author

Backported to stable-4.9 in commit c5b56a8

@fingolfin fingolfin added backport-to-4.9 release notes: added PRs introducing changes that have since been mentioned in the release notes labels Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: HPC-GAP unification topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Milestone
GAP 4.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ChrisJefferson